Fix formatter increment @line only on write#16762
Open
straight-shoota wants to merge 3 commits intocrystal-lang:masterfrom
Open
Fix formatter increment @line only on write#16762straight-shoota wants to merge 3 commits intocrystal-lang:masterfrom
@line only on write#16762straight-shoota wants to merge 3 commits intocrystal-lang:masterfrom
Conversation
straight-shoota
added
kind:bug
straight-shoota
force-pushed
the
fix/formatter-increment_lines
branch
from
b6882e8 to
d0f714f
Compare
Sija
reviewed
Mar 27, 2026
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formatter should never increment lines based on token locations from the lexer.
We can't assume that the output will have similar line breaks as the input. The formatter's job involves adding and removing line breaks to produce a well-formatted result.
With this patch,
@lineincrements in sync with writing to@output. This functionality is limited to#writeand#write_linemethods. Also the tracking ofno_rstrip_lineshappens in#writefor convenience, and to ensure correct line numbers.Resolves #16755
Depends on #16761